Forbid creation of link field type #6237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijreilly
commented
Jul 12, 2024
| if (fieldMetadataInput.type === FieldMetadataType.LINK) { | ||
| throw new FieldMetadataException( | ||
| '"Link" field types are being deprecated, please use Links type instead', | ||
| FieldMetadataExceptionCode.INVALID_FIELD_INPUT, |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Excluded 'Link' field type from being selectable in
/packages/twenty-front/src/pages/settings/data-model/SettingsObjectFieldEdit.tsx - Prevented creation of 'Link' field type in
/packages/twenty-front/src/pages/settings/data-model/SettingsObjectNewField/SettingsObjectNewFieldStep2.tsx - Added check to forbid 'LINK' field type creation in
/packages/twenty-server/src/engine/metadata-modules/field-metadata/field-metadata.service.ts - Ensure
FieldMetadataExceptionis thrown for 'LINK' field type creation attempts
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step of Link field type deprecation (#5909).
Forbid creation of link field type in product and api. Update to this type is not a concern as we do not allow the update of field type.